Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Sandox_st1_ms2_delivery.md #986

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Create Sandox_st1_ms2_delivery.md #986

merged 1 commit into from
Sep 5, 2023

Conversation

TradeLinkEstonia
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the Statemint account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1694

@dsm-w3f dsm-w3f self-assigned this Aug 31, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 31, 2023

@TradeLinkEstonia thank you for the milestone delivery. Please see the evaluation document and provide proper answers and fixes. Let me know when I can continue this evaluation.

@TradeLinkEstonia
Copy link
Contributor Author

TradeLinkEstonia commented Sep 4, 2023 •
edited
Loading

Hi, @dsm-w3f
we've fixed the issue with FireFox and supplemented the main readme file.
Also, we have udated the IDE to the latest version on the https://sandox.io web site

Please, check

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 4, 2023

@TradeLinkEstonia thank you for the improvements and fixes. We are almost finishing this evaluation. Just a small problem in Firefox yet. Please see the evaluation document. Let when I can continue this evaluation.

@TradeLinkEstonia
Copy link
Contributor Author

@dsm-w3f Diogo, we have fixed the lately mentioned FF-related bugs.
About displaying the column number of the cursor: as we didn't plan it in the 2nd Milestone and not to break the current work sprint, I suppose to deliver it in the 3rd Milestone. Is that ok?

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Sep 5, 2023

@TradeLinkEstonia thank you for the answer and fixes. It is okay to deliver this improvement in the next milestone. I checked again and now it works well with Firefox. The milestone is accepted. I'll forward your invoice internally and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 8957a66 into w3f:master Sep 5, 2023
6 checks passed
@RouvenP
Copy link

RouvenP commented Sep 11, 2023

hi @TradeLinkEstonia we just transferred the payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dsm-w3f dsm-w3f

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TradeLinkEstonia @dsm-w3f @RouvenP